Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: wolfram (original, original-wordmark, plain, plain-wordmark) #1828

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

new icon: wolfram (original, original-wordmark, plain, plain-wordmark) #1828

wants to merge 15 commits into from
+29 −0

Conversation

Tarang74
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://company.wolfram.com/press-center/

@Tarang74 Tarang74 marked this pull request as ready for review July 13, 2023 05:54
@Tarang74
Copy link
Author

Tarang74 commented Jul 13, 2023 •
edited
Loading

Includes wolframlanguage icon also

lunatic-fox
lunatic-fox requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there! 👋
Thank you for contributing with this project!

We need some fixes here.
Accordingly to their site Wolfram is a company and falls under a special case that we do not accept anymore:

However, Wolfram language works like a service and is allowed as an icon here.

That said you can:

  • Remove wolfram icons and directory.
  • Keep wolframlanguage directory and icon.
  • Add original-wordmark, plain and plain-wordmark versions of wolframlanguage.

Here goes some suggestions of the icons that need to be added:

original-wordmark plain plain-wordmark

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox changed the title new icons: wolfram (original, original-watermark) new icons: wolframlanguage (original, original-wordmark, plain, plain-wordmark) Jul 13, 2023
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 21, 2023
@Panquesito7 Panquesito7 requested a review from lunatic-fox July 21, 2023 06:20
lunatic-fox
lunatic-fox previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wolframlanguage icons are ok now.
Approved! ✔️
Screenshot from 2023-08-10 16-56-54
Screenshot from 2023-08-10 16-57-29

@Snailedlt Snailedlt changed the title new icons: wolframlanguage (original, original-wordmark, plain, plain-wordmark) new icon: wolframlanguage (original, original-wordmark, plain, plain-wordmark) Oct 21, 2023
@Snailedlt Snailedlt closed this Oct 21, 2023
@Snailedlt Snailedlt reopened this Oct 21, 2023
Snailedlt
Snailedlt previously requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I'm wondering why this is called wolframlanguage instead of wolfram and having wolframlanguage as an altname. Wolfram seems to be the official name, so that is what we should use.
If there is no particular reason, please change to wolfram

@lunatic-fox
Copy link
Contributor

Everything looks good, but I'm wondering why this is called wolframlanguage instead of wolfram and having wolframlanguage as an altname. Wolfram seems to be the official name, so that is what we should use. If there is no particular reason, please change to wolfram

Wolfram is a company and Wolfram Language is a service from that company, both share the same first name, but since it seems that are no other service that fits on the scope of Devicons I think it's ok to change it to wolfram instead and keep wolframlanguage as an altname. 👍🏼

@Snailedlt
Copy link
Collaborator

@Tarang74 Let us know if you need any help :)

@lunatic-fox lunatic-fox changed the title new icon: wolframlanguage (original, original-wordmark, plain, plain-wordmark) new icon: wolfram (original, original-wordmark, plain, plain-wordmark) Nov 5, 2023
lunatic-fox
lunatic-fox previously approved these changes Nov 5, 2023
View reviewed changes
@jessestuart jessestuart mentioned this pull request Nov 25, 2023
Open
@jessestuart jessestuart mentioned this pull request Dec 20, 2023
Open
@jessestuart jessestuart mentioned this pull request Apr 15, 2024
Open
canaleal
canaleal previously approved these changes May 6, 2024
View reviewed changes
@canaleal canaleal dismissed Snailedlt’s stale review May 6, 2024 01:00

Issue fixed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- Invalid path. This is not a directory: '/home/runner/work/devicon/devicon/icons/wolfram'.

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal dismissed stale reviews from lunatic-fox and themself via 08a05b5 May 6, 2024 02:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- Invalid path. This is not a directory: '/home/runner/work/devicon/devicon/icons/wolfram'.

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@jessestuart jessestuart mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox left review comments

@canaleal canaleal canaleal left review comments

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

@Gautam25Raj Gautam25Raj Awaiting requested review from Gautam25Raj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Tarang74 @lunatic-fox @Snailedlt @canaleal @Gautam25Raj @Panquesito7